Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new color for spoilers links #473

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

reda777
Copy link
Contributor

@reda777 reda777 commented May 22, 2024

Spoilers links will have a dashed pink underline. The issue suggested orange, but I think it will be hard to differentiate from red and yellow. Closes #471

ff80ce
ff80ce-visited

@ILiedAboutCake
Copy link
Collaborator

I might actually be colorblind because I cannot tell the difference here, we probably want to use something with a drastic different shade

@reda777
Copy link
Contributor Author

reda777 commented May 22, 2024

Pink looks fine to me:

  • nsfw:
    nsfw
  • nsfl:
    nsfl-yellow2
  • this pull request's pink:
    spoilers
  • darker pink:
    darker-pink-ff25ab
  • If you want to give up pink, green could work
    green-00ff40

@ILiedAboutCake ILiedAboutCake self-requested a review May 29, 2024 21:34
@11k 11k merged commit d7ea8d2 into destinygg:master May 29, 2024
2 checks passed
@ILiedAboutCake
Copy link
Collaborator

@reda777 Thanks for the contribution, Drop your DGG username or DM me on DGG and I'll throw a subscription your way for your efforts : D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight spoiler messages a different color
3 participants