This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Ensure Kotlin compilation task reruns when detekt config changes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
approved these changes
Sep 11, 2020
arturbosch
approved these changes
Sep 13, 2020
arturbosch
reviewed
Sep 13, 2020
src/main/kotlin/io/github/detekt/gradle/DetektKotlinCompilerPlugin.kt
Outdated
Show resolved
Hide resolved
BraisGabin
approved these changes
Sep 19, 2020
| .fold(byteArrayOf()) { acc, file -> acc + file } | ||
|
|
||
| return Base64.getEncoder().encodeToString( | ||
| MessageDigest.getInstance("SHA-256").digest(concatenatedConfig) |
There was a problem hiding this comment.
We could use DigestInputStream or something similar so we don't need to copy all the file in memory to compute the sha. But thinking about what detekt and the Compiler does this is clearly nothing so 🤐.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
This is definitely a bit of a hack, but until KT-41711 is resolved, I can't see a better option. I think the compiler plugin needs this feature because behaviour is surprising otherwise - you would reasonably expect a config file change would take effect the next time a compilation task is run.