chore: upgrade Go from 1.18 -> 1.20 #5981
Conversation
✅ Deploy Preview for determined-ui canceled.
|
NicholasBlaskey
force-pushed
the
upgrade_go
branch
3 times, most recently
from
62c5282 to
6cd13e4
Compare
| @@ -1035,14 +1037,15 @@ jobs: | |||
|
|
|||
| package-and-push-system-local: | |||
| docker: | |||
| - image: cimg/go:1.18 | |||
There was a problem hiding this comment.
cimg/go:1.20 doesn't work here due to glibc issues
Go 1.20 seems to cause us to have a higher glibc version than ubuntu 20.04 supports when we build with this image with a base of ubuntu 22.04. I think the fact it worked before was a happy accident relying on precompiled object files that shipped with the Go compiler.
Maybe we should just add this to the determined-ci? Though I don't really understand why we have this reinstall-go step (besides me using it now to get Go 1.20).
We could also possibly look into CGO_ENABLED=0 but feels like there is a risk that it might cause a nebulous performance issue for some setup.
| @@ -361,7 +361,7 @@ func (db *PgDB) queryRowsWithParser( | |||
| panic(fmt.Sprintf("unsupported query type: %s", kind)) | |||
| } | |||
|
|
|||
| if err := rows.Close(); err != nil { | |||
| if err := rows.Close(); err != nil { //nolint: sqlclosecheck | |||
There was a problem hiding this comment.
we correctly defer rows.Close() above so not sure why this linter is complaining
|
#5975 added go version check |
| @@ -15,7 +15,7 @@ As far as translation makes possible, the original algorithm, variable names, an | |||
| unmodified. The accompanying tests were added after the Go rewrite. The following copyright notice | |||
| and the MIT license pertain to the original implementation: | |||
|
|
|||
| Copyright (c) 2013 by Sveinn Steinarsson | |||
| # Copyright (c) 2013 by Sveinn Steinarsson | |||
NicholasBlaskey
force-pushed
the
upgrade_go
branch
from
b304913 to
b69c7c3
Compare
Description
Upgrades Go to 1.20.
Test Plan
CI passes.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket