feat: replace clone function with structuredClone and add polyfill

[thiagodallacqua-hpe]

Ticket: WEB-946

This PR intends to convert the current structure into using the available structuredClone and add a polyfill for it.

Description

Test Plan

there're a few places where the clone function is used, I suggest testing with the hyperparameter search modal, as it clones with the previous arg for deep as true.

Commentary (optional)

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	74e72ce
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/64e4e15dee51870008d7883c
😎 Deploy Preview	https://deploy-preview-7624--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[keita-determined]

seems like .swcrc is not working as expected

[ashtonG]

We only use swc for transpilation in dev -- in production we use esbuild. Can you confirm the swc polyfill method works on older browsers with a production bundle?

[thiagodallacqua-hpe]

We only use swc for transpilation in dev -- in production we use esbuild. Can you confirm the swc polyfill method works on older browsers with a production bundle?

After adding the polyfill back, I've checked the preview link on chrome 97 and it works.

[keita-determined]

tested on local chromium v93 and its mostly good in production mode
but polyfill is not applied on dev mode. do we wanna support it in dev mode too?

[ashtonG]

circling back, i'm noticing that by default the old clone did a shallow clone and we only need deep clones (i.e., what structuredClone does) when true is passed to the "deep" argument.

can we replace calls that would have been shallow clones with the object spread instead to keep the semantics consistent?

[thiagodallacqua-hpe]

circling back, i'm noticing that by default the old clone did a shallow clone and we only need deep clones (i.e., what structuredClone does) when true is passed to the "deep" argument.

can we replace calls that would have been shallow clones with the object spread instead to keep the semantics consistent?

I looked at this, as the old clone had the arg deep = true, and I couldn't find any call signature with clone(<cloned_stuff>, false)...

clone = (data: any, deep = true): any => // ...

[keita-determined]

tested on local chromium v93 and its mostly good in production mode but polyfill is not applied on dev mode. do we wanna support it in dev mode too?

@ashtonG do you think polyfill should be applied in dev? or we expect engineers to use the latest browser so it doesn't matter?

[ashtonG]

i'd be suprised the polyfill isn't working in dev -- barring an explicit IS_DEV switch, i'd expect the module doing the pollyfilling to work the same regardless.

@thiagodallacqua-hpe can you investigate what's happening here?

[keita-determined]

Looks mostly good, but i got an issue in the new exp table.
in Chrome v116, the new exp table doesn't show data correctly. I didn't see the issue in main branch so i think this PR introduced the issue.

Screen.Recording.2023-08-21.at.11.26.37.AM.mov

[keita-determined]

Could you change the appropriate PR title?