Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash when not calling ma_audio_unint correctly #397

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Fixes crash when not calling ma_audio_unint correctly #397

merged 2 commits into from
Jul 20, 2024

Conversation

dethrace-labs
Copy link
Owner

@dethrace-labs dethrace-labs commented Jul 20, 2024 •
edited
Loading

AudioBackend_StopCDA doesn't call ma_audio_unint if the track has already finished playing.

  • Adds call to ma_audio_unint if necessary
  • Adds call to AudioBackend_StopCDA inside AudioBackend_PlayCDA to ensure we are not still playing the previous track

Fixes #396

b-kurczynski
b-kurczynski reviewed Jul 20, 2024
View reviewed changes
Copy link
Contributor

@b-kurczynski b-kurczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it must work 👍 Thank you!

@dethrace-labs dethrace-labs merged commit ec04a9c into main Jul 20, 2024
6 checks passed
@dethrace-labs dethrace-labs deleted the fix-396 branch July 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-kurczynski b-kurczynski b-kurczynski approved these changes

@madebr madebr madebr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Game crashing at random using dethrace-e757db4-windows-x64
3 participants
@dethrace-labs @madebr @b-kurczynski