Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

エラー処理修正・format用CI追加 #33

Merged
merged 5 commits into from
Jan 16, 2024
Merged

エラー処理修正・format用CI追加 #33

merged 5 commits into from
Jan 16, 2024

Conversation

massongit
Copy link
Member

@massongit massongit commented Jan 14, 2024 •
edited
Loading

エラー処理を以下のように修正します。

  • エラー発生時に異常終了する
  • エラー発生時にスタックトレースを表示する

また、GoのFormat用CIを追加します。

This was referenced Jan 14, 2024
Merged
Merged
@github-actions
Format修正 (#35)
c50c036 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
fail-notifyが間違ってたので直してあげたよ！ (#34)
ddcc0ee 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@massongit massongit changed the title エラー処理修正 エラー処理修正・format用CI追加 Jan 14, 2024
@massongit massongit requested a review from Goryudyuma January 14, 2024 13:42
Goryudyuma
Goryudyuma reviewed Jan 15, 2024
View reviewed changes
main.go Show resolved Hide resolved
Goryudyuma
Goryudyuma approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Goryudyuma Goryudyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まあapproveはしておきます。

@massongit massongit requested a review from Goryudyuma January 16, 2024 14:44
@massongit massongit added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit dc771c1 Jan 16, 2024
17 checks passed
@massongit massongit deleted the fix_display_error branch January 16, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goryudyuma Goryudyuma Goryudyuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
task list
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massongit @Goryudyuma