[mysql_hardening] Allow setting the mysql_distribution #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some operating systems, the package for MySQL is not `mysql-server`, and so the default check for this will not yield the correct result. This change adds an escape hatch by letting the user set `mysql_distribution`. Additionally, it verifies that it is set to a legal value if the user has set it. Closes dev-sec#472 Signed-off-by: Shawn Wilsher <[email protected]>
sdwilsh
force-pushed
the
mysql_distribution
branch
from
23dae2f to
42dd253
Compare
sdwilsh
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Aug 13, 2021
Everything after the TODO can be removed after these two PRs are released: * dev-sec/ansible-collection-hardening#473 * dev-sec/ansible-collection-hardening#474
rndmh3ro
reviewed
Aug 15, 2021
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* [mysql_hardening] Allow setting the mysql_distribution On some operating systems, the package for MySQL is not `mysql-server`, and so the default check for this will not yield the correct result. This change adds an escape hatch by letting the user set `mysql_distribution`. Additionally, it verifies that it is set to a legal value if the user has set it. Closes dev-sec#472 Signed-off-by: Shawn Wilsher <[email protected]> * Update roles/mysql_hardening/tasks/main.yml Co-authored-by: Sebastian Gumprich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some operating systems, the package for MySQL is not
mysql-server,and so the default check for this will not yield the correct result.
This change adds an escape hatch by letting the user set
mysql_distribution. Additionally, it verifies that it is set to alegal value if the user has set it.
Closes #472