OpenBSD does not set distributiuon_major_version #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable. Can you fix the linting please? Also please sign-off your commits (see https://github.com/dev-sec/ansible-collection-hardening/pull/597/checks?check_run_id=9290990385) |
This role fails with `The task includes an option with an undefined variable` on OpenBSD because `distributiuon_major_version` is not set on OpenBSD. We should either default to "" if the variable is not set, or remove `vars/OpenBSD.yml`. I would prefer the former :) Signed-off-by: Dennis Eriksen <[email protected]>
|
There :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This role fails with
The task includes an option with an undefined variableon OpenBSD becausedistributiuon_major_versionis not set on OpenBSD.We should either default to "" if the variable is not set, or remove
vars/OpenBSD.yml. I would prefer the former :)