Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add testing for OpenBSD and FreeBSD #642

Merged
merged 28 commits into from
Mar 31, 2023
Merged

add testing for OpenBSD and FreeBSD #642

merged 28 commits into from
Mar 31, 2023

Conversation

schurzi
Copy link
Contributor

@schurzi schurzi commented Feb 25, 2023

No description provided.

schurzi added 12 commits February 25, 2023 11:12
@schurzi
add testing for OpenBSD and FreeBSD
bf12d75 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
make python work
00201c8 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
remove jinja template ...
021f360 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
make verify work
884ac42 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct verify
2a81300 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct verify
fc16ba7 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct verify
3be7ae4 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct verify
ee6435e 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
use right vm name for connect
b67efa4 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
add a bit of documentation
abf440c 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
remove sudo
e65c868 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
add weird OpenSBD workaround
1e59fff 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
Copy link
Contributor Author

schurzi commented Feb 25, 2023 •
edited
Loading

weird find of the day, inspec handles OpenBSD as UNIX and thinks it needs to use type instead of which to determine if a command exists.
https://github.com/inspec/inspec/blob/4b9cf11096a02a6d2396a8976276d1a0c9c5746a/lib/inspec/resources/command.rb#L87-L88

@schurzi schurzi marked this pull request as ready for review February 25, 2023 14:33
@schurzi schurzi requested a review from rndmh3ro February 25, 2023 14:33
@schurzi
Copy link
Contributor Author

schurzi commented Feb 25, 2023

So @rndmh3ro what do you think? Are these tests a benefit or are the just a nuisance in the long run?

The remaining errors would need to be addressed but the testing basically works as expected.

@schurzi
Copy link
Contributor Author

schurzi commented Feb 25, 2023

I was originally also planning to add tests for SmartOS, but this in an extra can of worms ...

@schurzi schurzi linked an issue Feb 27, 2023 that may be closed by this pull request
Support BSD and other operating systems CI with VM based tests #599
Closed
@schurzi
Copy link
Contributor Author

schurzi commented Mar 9, 2023

add waivers for unsupported controls
add bsd support to metadata for ssh role

schurzi added 5 commits March 15, 2023 21:13
@schurzi
rename nonlinux to BSD
3c7be2e 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
use openbsd7 for testing
859febf 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct use openbsd7 everywhere
38d7b8b 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
add waivers
f7afb4e 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
update waiver descriptions
26e0e7b 
Signed-off-by: Martin Schurz <[email protected]>
schurzi added 7 commits March 15, 2023 22:22
@schurzi
use docker for inspec
57fdd35 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
keep looking right ;)
ef2f571 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
correct path to waivers
115cd1e 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
use ephemeral directory in docker
78607fb 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
use bsd inspec profile
f57d6dc 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
remove openbsd workaround
9d44a65 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
re-add openbsd workaround
bf40ee7 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi schurzi mentioned this pull request Mar 15, 2023
Merged
rndmh3ro
rndmh3ro approved these changes Mar 16, 2023
View reviewed changes
.github/workflows/ssh_hardening_bsd.yml Outdated Show resolved Hide resolved
.github/workflows/ssh_hardening_bsd.yml Outdated Show resolved Hide resolved
molecule/ssh_hardening_bsd/verify.yml Outdated Show resolved Hide resolved
molecule/ssh_hardening_bsd/verify.yml Outdated Show resolved Hide resolved
schurzi added 3 commits March 27, 2023 21:18
@schurzi
commit suggestions
a1b836e 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
add supportet OS to metadata
33af596 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
use current python
8c5f64a 
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
Copy link
Contributor Author

schurzi commented Mar 27, 2023

everything should now be taken care of. Ready for review @rndmh3ro

@rndmh3ro rndmh3ro merged commit 29f8a2f into master Mar 31, 2023
@rndmh3ro rndmh3ro deleted the ssh_bsd_vm branch March 31, 2023 07:50
@rndmh3ro
Copy link
Member

Great work @schurzi! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndmh3ro rndmh3ro rndmh3ro approved these changes

Assignees
No one assigned
Labels
enhancement minor ssh_hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support BSD and other operating systems CI with VM based tests
2 participants
@schurzi @rndmh3ro