Add oddjob mkhomedir option rhel pam #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add the variable to the readme, with a description? And please sign-off your commits as described here: https://github.com/dev-sec/ansible-collection-hardening/pull/675/checks?check_run_id=13660004577 Other than that: looks good! |
added 5 commits
May 22, 2023 16:12
Signed-off-by: Jochen Demmer <[email protected]>
Signed-off-by: Jochen Demmer <[email protected]>
Signed-off-by: Jochen Demmer <[email protected]>
Signed-off-by: Jochen Demmer <[email protected]>
|
Ok, what's wrong with the variable names (Ansible Lint)? I don't get it. |
|
It's a new requirement, you can ignore it. |
schurzi
reviewed
May 23, 2023
| @@ -47,6 +47,9 @@ password required pam_deny.so | |||
| session optional pam_keyinit.so revoke | |||
| session required pam_limits.so | |||
| -session optional pam_systemd.so | |||
| {% if (os_auth_pam_oddjob_mkhomedir | bool) %} | |||
| session optional pam_oddjob_mkhomedir.so umask=0077 | |||
There was a problem hiding this comment.
sorry for being late to the party.
We have a special variable fo setting the expected umask (os_env_umask). While checking for this, I also found, that this setting might be ignored, because of authselect/authselect#223
So no real problem here, but a minor inconvenience from my point of view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mkhomedir option for RedHat based systems, e.g. in FreeIPA environments.