add var-naming[no-role-prefix] to skip-list #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's probably some added value for this, but I see no reason to change so many variables and possibly break something when it still works and nobody complained Signed-off-by: Sebastian Gumprich <[email protected]>
schurzi
approved these changes
May 26, 2023
There was a problem hiding this comment.
I agree. Altough there is some possibility of naming collisions (eg. users_accounts is a very generic variable name) but we had no problems up to now and looking at the other PR #678 this will blow up a lot of places with very long variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's probably some added value for this, but I see no reason to change so many variables and possibly break something when it still works and nobody complained