-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workflow for roles readme #705
Conversation
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome that you did this! Thanks!
I left some comments to simplify the code.
Co-authored-by: Sebastian Gumprich <[email protected]> Signed-off-by: Nemental <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]> Signed-off-by: Nemental <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]> Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Thank you also for your code suggestions - the changes have been implemented. |
Maybe I should add a diff or other output step after README creation to show the differences/results? |
Signed-off-by: Nemental <[email protected]>
I thought about that. In general it's a good idea, so let's keep the git diff action there. But then I also thought: why not let the action update the README in the pull-request? This way the author of the PR doesn't have to check the diff and correct it, it get's corrected automatically. Could you therefore try this push-action?
With omitting the branch, it should push top the branch where the action gets executed. With omitting the author, it should use the author for the PR, I hope. |
You or I could also do this in another PR, if you want to get this merged, first! |
great thoughts, thanks! I would like to test this myself. I gratefully accept any opportunity to practice GitHub workflow. 😄✌️ |
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Damn, okay, now it has to work :D |
Signed-off-by: Nemental <[email protected]>
Signed-off-by: Nemental <[email protected]>
Maybe just run a git diff without any arguments? |
Signed-off-by: Nemental <[email protected]>
Seems that pushing to a fork is not easily possible. So instead, let's just push to the master branch when the action is running from master, like you initially did. |
Signed-off-by: Nemental <[email protected]>
No, I don't want to give up yet. As I can see from the logs, the branch name is the problem. Give me one more try. |
Why does commit-action want to use |
Signed-off-by: Nemental <[email protected]>
This PR will be my personal nemesis. |
The action is running in the dev sec orga, not in your fork. So it checks it out as the number of the PR. The /merge is to show that your changes are merged into master before running the action. |
If
|
Thanks! Let's see what happens! |
Workflow for creation of roles README.md with aar-doc.
Fixes #694