Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing and support for current versions of Fedora and FreeBSD #709

Merged
merged 14 commits into from
Nov 16, 2023

Conversation

schurzi
Copy link
Contributor

@schurzi schurzi commented Nov 10, 2023

No description provided.

Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
@schurzi
Copy link
Contributor Author

schurzi commented Nov 15, 2023

@rndmh3ro ready for review.

I had to explicitly add /tmp to mountpoints_list since mounts based on tmpfs are not in the Ansible variable. This should be no problem. Basically this made our role always skip /tmp if it was mounted as a tmpfs. We do not harden it by default, so this should be finde. But everyone who has had hardening for /tmp configured has not had the hardening applied until now. So this might be a breaking change.

@rndmh3ro
Copy link
Member

Thanks, LGTM!

But everyone who has had hardening for /tmp configured has not had the hardening applied until now. So this might be a breaking change.

If this wasn't working but should have, its just a bugfix to me.

@rndmh3ro rndmh3ro merged commit 3d98cbf into master Nov 16, 2023
70 checks passed
@rndmh3ro rndmh3ro deleted the fedora39 branch November 16, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants