Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centos7 is eol, remove it #767

Merged
merged 3 commits into from
May 31, 2024
Merged

centos7 is eol, remove it #767

merged 3 commits into from
May 31, 2024

Conversation

rndmh3ro
Copy link
Member

No description provided.

@rndmh3ro rndmh3ro requested a review from schurzi May 30, 2024 13:24
schurzi
schurzi requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update all the meta.yml files.

I took a look at the code and ther are some tasks in our tests, that are only used for el7, in the roles there are no expected changes.

Is dropping compatibility in this case a mayor or rather a minor update?

@rndmh3ro
Copy link
Member Author

Is dropping compatibility in this case a mayor or rather a minor update?

Major. According to semver, we should do a minor-release, deprecating centos7 support there, then a major-release to remove it, but honestly I'd just skip that.

@schurzi schurzi added the major label May 31, 2024
schurzi
schurzi requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also missed the READMEs ... sorry

@rndmh3ro
Copy link
Member Author

I missed them, you spotted them.

@rndmh3ro
Copy link
Member Author

Hold on. These should be updated automatically. I'll fix the workflow.

schurzi
schurzi requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are right! But AAR docs only cover the README of roles, our global README also needs an update ;)

@rndmh3ro rndmh3ro merged commit 296f46c into master May 31, 2024
89 of 91 checks passed
@rndmh3ro rndmh3ro deleted the centos7_eol branch May 31, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schurzi schurzi schurzi approved these changes

Assignees
No one assigned
Labels
major mysql_hardening nginx_hardening os_hardening ssh_hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndmh3ro @schurzi