Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ssh is installed (cf #771) #774

Merged
merged 1 commit into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/ssh_hardening/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---

# true if IPv6 is needed
network_ipv6_enable: true # sshd + ssh

Expand Down
6 changes: 0 additions & 6 deletions roles/ssh_hardening/tasks/disable-systemd-socket.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,3 @@
state: stopped
enabled: false
masked: true

- name: Enable normal sshd start
ansible.builtin.systemd:
name: ssh.service
state: started
enabled: true
12 changes: 3 additions & 9 deletions roles/ssh_hardening/tasks/hardening.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
with_dict: "{{ os_vars }}"
tags: always

- name: Install openssh package and configure the service
ansible.builtin.include_tasks: install.yml

- name: Get openssh-version
ansible.builtin.command: ssh -V
register: sshd_version_raw
Expand All @@ -32,15 +35,6 @@
ansible.builtin.set_fact:
sshd_version: "{{ sshd_version_raw.stderr | regex_replace('.*_([0-9]*.[0-9]).*', '\\1') }}"

# see https://github.com/dev-sec/ansible-collection-hardening/issues/763
- name: Change Debian/Ubuntu systems so ssh starts traditionally instead of socket-activated
ansible.builtin.include_tasks: disable-systemd-socket.yml
when:
- ssh_server_hardening | bool
- ssh_server_enabled | bool
- (ansible_facts.distribution == 'Ubuntu' and ansible_facts.distribution_major_version is version('22.04', '>=')) or
(ansible_facts.os_family == 'Debian' and ansible_facts.distribution_major_version is version('12', '>='))

- name: Set default for ssh_host_key_files if not supplied
ansible.builtin.include_tasks: crypto_hostkeys.yml
when:
Expand Down
23 changes: 23 additions & 0 deletions roles/ssh_hardening/tasks/install.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---

- name: Install openssh package(s)
ansible.builtin.package:
name: "{{ pkg }}"
state: present
loop: "{{ ssh_pkgs }}"
loop_control:
loop_var: pkg

# see https://github.com/dev-sec/ansible-collection-hardening/issues/763
- name: Change Debian/Ubuntu systems so ssh starts traditionally instead of socket-activated
ansible.builtin.include_tasks: disable-systemd-socket.yml
when:
- ssh_server_hardening | bool
- ssh_server_enabled | bool
- (ansible_facts.distribution == 'Ubuntu' and ansible_facts.distribution_major_version is version('22.04', '>=')) or
(ansible_facts.os_family == 'Debian' and ansible_facts.distribution_major_version is version('12', '>='))

- name: Enable or disable sshd service
ansible.builtin.service:
name: "{{ sshd_service_name }}"
enabled: "{{ ssh_server_service_enabled }}"
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/Amazon_2.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/Archlinux.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
3 changes: 3 additions & 0 deletions roles/ssh_hardening/vars/Debian.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
---
ssh_pkgs:
- openssh-server
- openssh-client
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: ssh
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/Fedora.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/Fedora_37.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/FreeBSD.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh-portable
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
4 changes: 4 additions & 0 deletions roles/ssh_hardening/vars/OpenBSD.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
---
# It seems that OpenBSD comes with openssh in the base install so we can't
# really install it as a separated package. Feel free to patch this if it's
# not the expected way to handle that on OpenBSD
ssh_pkgs: []
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/RedHat.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/RedHat_9.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/SmartOS.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/lib/ssh/sshd
ssh_host_keys_dir: /var/ssh
sshd_service_name: ssh
Expand Down
2 changes: 2 additions & 0 deletions roles/ssh_hardening/vars/Suse.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
ssh_pkgs:
- openssh
sshd_path: /usr/sbin/sshd
ssh_host_keys_dir: /etc/ssh
sshd_service_name: sshd
Expand Down
1 change: 1 addition & 0 deletions roles/ssh_hardening/vars/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---

ssh_macs_53_default:
- hmac-ripemd160
- hmac-sha1
Expand Down