Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document correct quotes for ssh_permit_tunnel parameter #806

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

vmpr
Copy link
Contributor

@vmpr vmpr commented Oct 10, 2024

…cs.yml

ssh_permit_tunnel needs quotes otherwise we will end up with an error:

TASK [devsec.hardening.ssh_hardening : Create sshd_config and set permissions to root/600] **********************************************************************************************************************
fatal: [vampdock02]: FAILED! => {"changed": false, "checksum": "fe6b74e30b1a653f83c2cbe1dd1332c14bd55833", "exit_status": 255, "msg": "failed to validate", "stderr": "/home/debian/.ansible/tmp/ansible-tmp-1728530891.493071-72386-149151737175948/source line 123: bad PermitTunnel argument True\r\n", "stderr_lines": ["/home/debian/.ansible/tmp/ansible-tmp-1728530891.493071-72386-149151737175948/source line 123: bad PermitTunnel argument True"], "stdout": "", "stdout_lines": []}

…cs.yml

ssh_permit_tunnel needs quotes otherwise we will end up with an error:
```
TASK [devsec.hardening.ssh_hardening : Create sshd_config and set permissions to root/600] **********************************************************************************************************************
fatal: [vampdock02]: FAILED! => {"changed": false, "checksum": "fe6b74e30b1a653f83c2cbe1dd1332c14bd55833", "exit_status": 255, "msg": "failed to validate", "stderr": "/home/debian/.ansible/tmp/ansible-tmp-1728530891.493071-72386-149151737175948/source line 123: bad PermitTunnel argument True\r\n", "stderr_lines": ["/home/debian/.ansible/tmp/ansible-tmp-1728530891.493071-72386-149151737175948/source line 123: bad PermitTunnel argument True"], "stdout": "", "stdout_lines": []}
```
@schurzi schurzi changed the title fixing missing quotes for ssh_permit_tunnel parameter in argument_spe… Document correct quotes for ssh_permit_tunnel parameter Oct 10, 2024
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are required!

Actually the quotes are only required for parameters that will be interpreted as boolean by YAML. But for the sake of consistency we'll leave the text as is. ;)

@schurzi schurzi merged commit 3923ea8 into dev-sec:master Oct 10, 2024
33 of 37 checks passed
@vmpr vmpr deleted the patch-2 branch October 10, 2024 11:46
@vmpr
Copy link
Contributor Author

vmpr commented Oct 10, 2024

The quotes are required!

Actually the quotes are only required for parameters that will be interpreted as boolean by YAML. But for the sake of consistency we'll leave the text as is. ;)

Thatswhy I only added quotes to yes and no ;) cheers mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants