Update kitchen config for more platforms #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-sidorenko
requested changes
May 11, 2018
There was a problem hiding this comment.
@tas50 thank you! Looks good to me. May I ask you to add debian-9 to the DO tests?
| @@ -23,9 +23,6 @@ platforms: | |||
| - name: centos-7 | |||
| driver_config: | |||
| image: centos-7-x64 | |||
| - name: debian-7 | |||
| driver_config: | |||
| image: debian-7-x64 | |||
| - name: debian-8 | |||
| driver_config: | |||
| image: debian-8-x64 | |||
There was a problem hiding this comment.
@tas50 can you please add debian-9 here? image is debian-9-x64
| @@ -20,20 +20,20 @@ env: | |||
| - INSTANCE=centos-6 KITCHEN_LOCAL_YAML=.kitchen.do.yml | |||
| - INSTANCE=centos-7 KITCHEN_LOCAL_YAML=.kitchen.do.yml | |||
| - INSTANCE=centos-7 CHEF_VERSION=12.14.60 KITCHEN_LOCAL_YAML=.kitchen.do.yml | |||
| - INSTANCE=debian-7 KITCHEN_LOCAL_YAML=.kitchen.do.yml | |||
| - INSTANCE=debian-8 KITCHEN_LOCAL_YAML=.kitchen.do.yml | |||
There was a problem hiding this comment.
@tas50 can you please add debian-9 here?
chris-rock
approved these changes
May 14, 2018
There was a problem hiding this comment.
@tas50 Thank you for this improvement. I propose we split Ubuntu 18.04 into own PR, since we need to investigate why the log group from the baseline does not fit https://github.com/dev-sec/linux-baseline/blob/master/controls/os_spec.rb#L21
| <% if ENV['CHEF_VERSION'] %> | ||
| chef_version: <%= ENV['CHEF_VERSION'] %> | ||
| <% end %> | ||
| chef_version: <%= ENV['CHEF_VERSION'] || 'current' %> |
It's EOL Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]> Signed-off-by: Tim Smith <[email protected]>
Add Ubuntu 18.04 / Debian 9 We push bento images named after the major release now that get updated for all the minors. No need to update the config all the time with the new box names Signed-off-by: Tim Smith <[email protected]>
Add Ubuntu 18.04 / Debian 9 Use the dokken images that already have packages like procps in them Order the platforms alphabetically Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
till we resolved all problems Signed-off-by: Artem Sidorenko <[email protected]>
inspec/train#312 Signed-off-by: Artem Sidorenko <[email protected]>
artem-sidorenko
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the configs by using dokken images and bento slugs. Make sure to fail on deprecation warnings to keep the cookbook ready for upcoming chef releases. Also add testing of Debian 9 / Ubuntu 18.04 and remove EOL Debian 7