Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting uid/gid max by attribute #215

Merged
merged 1 commit into from
May 16, 2018
Merged

allow setting uid/gid max by attribute #215

merged 1 commit into from
May 16, 2018

Conversation

mattlqx
Copy link
Contributor

@mattlqx mattlqx commented May 14, 2018

This change un-hardcodes the maximum user and group IDs assigned by useradd and groupadd respectively. Having them hardcoded can present problems for nodes that are configured with directory services (e.g. LDAP) and the range conflicts with IDs from there. These attributes will allow users to configure a non-conflicting ID range.

Signed-off-by: Matt Kulka [email protected]

This change un-hardcodes the maximum user and group IDs assigned by useradd and groupadd respectively. Having them hardcoded can present problems for nodes that are configured with directory services (e.g. LDAP) and the range conflicts with IDs from there. These attributes will allow users to configure a non-conflicting ID range.

Signed-off-by: Matt Kulka <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3bff663 on mattlqx:id-max into ec10539 on dev-sec:master.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @mattlqx

@chris-rock chris-rock merged commit e05934a into dev-sec:master May 16, 2018
@mattlqx mattlqx mentioned this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants