-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 18.04 is supported #223
Conversation
I see that Ubuntu 18.04 is included in Travis (with no specific config for allowed errors). I guess it means that 18.04 is supported. This PR adds 18.04 to the readme. |
@frederikbosch there are still some errors which needs to be fixed:
:-( |
Thanks. Is it correct that these are the two failures?
|
If so, I'll look into the errors and see if I can fix them. |
@frederikbosch I saw only the log permissions failure, but maybe I missed something else. |
@artem-sidorenko Alright, I'll see what I can do to update this PR to include full support of Ubuntu 18.04. |
@frederikbosch great! Thank you! |
ba2dba0
to
457ef98
Compare
This PR is updated. First, I have created a fix in the baseline package, see #100. That PR fixes all the tests for 18.04 here, and also the allowed failure of Please be aware that this PR uses my forked baseline package in the inspec dependencies to run the tests against. After merging the baseline fix, this PR has to be updated and restore the dependency. @artem-sidorenko I would love to see the PR at the baseline merged, then we can update and merge this PR too. |
@frederikbosch I'm currently not sure how to resolve it or what the reason is there for a missing rsyslog installation. I try to have a deeper look here in the next days |
@frederikbosch btw, thanks for your work! |
457ef98
to
8ea268c
Compare
@frederikbosch thank you! |
Update README.md to include support for Ubuntu 18.04.