Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 18.04 is supported #223

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

frederikbosch
Copy link
Contributor

Update README.md to include support for Ubuntu 18.04.

@frederikbosch
Copy link
Contributor Author

I see that Ubuntu 18.04 is included in Travis (with no specific config for allowed errors). I guess it means that 18.04 is supported. This PR adds 18.04 to the readme.

@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 457ef98 on frederikbosch:patch-1 into f358ee2 on dev-sec:master.

@artem-sidorenko
Copy link
Member

@frederikbosch
Copy link
Contributor Author

Thanks. Is it correct that these are the two failures?

  • os-11: Protect log-directory (1 failed). Test: File /var/log should be grouped into "syslog
  • Recipe: os-hardening::pam (tally2)

@frederikbosch
Copy link
Contributor Author

If so, I'll look into the errors and see if I can fix them.

@artem-sidorenko
Copy link
Member

@frederikbosch I saw only the log permissions failure, but maybe I missed something else.

@frederikbosch
Copy link
Contributor Author

@artem-sidorenko Alright, I'll see what I can do to update this PR to include full support of Ubuntu 18.04.

@artem-sidorenko
Copy link
Member

@frederikbosch great! Thank you!

@frederikbosch frederikbosch force-pushed the patch-1 branch 2 times, most recently from ba2dba0 to 457ef98 Compare August 6, 2018 17:16
@frederikbosch
Copy link
Contributor Author

This PR is updated. First, I have created a fix in the baseline package, see #100. That PR fixes all the tests for 18.04 here, and also the allowed failure of INSTANCE=ubuntu-16-04 KITCHEN_LOCAL_YAML=.kitchen.dokken.yml for Ubuntu 16.04.

Please be aware that this PR uses my forked baseline package in the inspec dependencies to run the tests against. After merging the baseline fix, this PR has to be updated and restore the dependency.

@artem-sidorenko I would love to see the PR at the baseline merged, then we can update and merge this PR too.

@artem-sidorenko
Copy link
Member

@frederikbosch I'm currently not sure how to resolve it or what the reason is there for a missing rsyslog installation. I try to have a deeper look here in the next days

@artem-sidorenko artem-sidorenko self-assigned this Aug 7, 2018
@artem-sidorenko
Copy link
Member

@frederikbosch btw, thanks for your work!

@artem-sidorenko
Copy link
Member

@frederikbosch thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants