Do not apply exec-shield if running Oracle Linux with UEK - addresses #234 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Spies <[email protected]>
|
Shoot, I didn't create a branch first, let me know if I need to go back and redo this in a branch per the CONTRIBUTING file... I also did not see any unit tests around this feature so did not make any updates to the unit tests, but I can if that is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Oracle support notes, exec-shield was removed from UEK.
I am having a hard time testing this update since it requires much older versions of Chef libraries and is using older Rubocop settings. If there is documentation on testing specifically with Chef 12, feel free to point me in that direction.
This addresses #234 and if possible it would be great to include in #233