Skip to content

Commit

Permalink
fix: fixes for path mappings, tests, and coverage (angular#1359)
Browse files Browse the repository at this point in the history
* fix(): Multiple fixes for path mappings:

* Removed invalid test case that was throwing path mappings  tests because of a typescript bug.
* Readded PathsPlugin for Path Mappings
* Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be.
* Added sourcemap support for istanbul instrumenter. Coverage files are still being generated.

* fix: fix the way the build command runs for mobile tests

* fix: fix the way the build command runs for mobile tests

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile
  • Loading branch information
TheLarkInn authored and johannes.werner committed Sep 11, 2016
1 parent 4d25492 commit c838dab
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
3 changes: 1 addition & 2 deletions addon/ng2/models/webpack-build-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export const getWebpackTestConfig = function(projectRoot: string) {
query: {
useWebpackText: true,
tsconfig: path.resolve(projectRoot, './src/tsconfig.json'),
// resolveGlobs: false,
module: "commonjs",
target: "es5",
useForkChecker: true,
Expand All @@ -67,7 +66,7 @@ export const getWebpackTestConfig = function(projectRoot: string) {
],
postLoaders: [
{
test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
test: /\.(js|ts)$/, loader: 'sourcemap-istanbul-instrumenter-loader',
exclude: [
/\.(e2e|spec)\.ts$/,
/node_modules/
Expand Down
3 changes: 0 additions & 3 deletions addon/ng2/utilities/ts-path-mappings-webpack-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ export class PathsPlugin implements ResolverPlugin {
this.baseUrl
);

console.log("CONFIG FILE AND BASE URL");
console.log(this.configFilePath, this.absoluteBaseUrl);

this.mappings = [];
let paths = this.options.paths || {};
Object.keys(paths).forEach(alias => {
Expand Down

0 comments on commit c838dab

Please sign in to comment.