Support addressing lights by IP address #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit there was no way to control bulbs that were on a different network that homebridge. The only discovery method was through network broadcasts, which won't work across VLANs. The node-lifx library supports addressing bulbs by their IP, but this homebridge plugin did not. This commit adds support by adding the "lights" configuration option that accepts an array of IP addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit there was no way to control bulbs that were on a
different network that homebridge. The only discovery method was through
network broadcasts, which won't work across VLANs.
The node-lifx library supports addressing bulbs by their IP, but this
homebridge plugin did not. This commit adds support by adding the
"lights" configuration option that accepts an array of IP addresses.