Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set-up command #378

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Add set-up command #378

merged 1 commit into from
Jan 19, 2023

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jan 19, 2023

The additional set-up command will allow the Dev Containers extension to use the CLI for attaching to an existing container.

The commands run-user-commands, read-configuration and exec also needed changes to support running without a workspace folder and without a config file.

microsoft/vscode-remote-release#7872

@chrmarti chrmarti force-pushed the chrmarti/coastal-pinniped branch 2 times, most recently from c4e0ea1 to 7a86593 Compare January 19, 2023 19:01
@chrmarti chrmarti force-pushed the chrmarti/coastal-pinniped branch from 7a86593 to 5793e9e Compare January 19, 2023 19:22
@chrmarti chrmarti marked this pull request as ready for review January 19, 2023 19:36
@chrmarti chrmarti requested a review from a team as a code owner January 19, 2023 19:36
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ⚡

src/spec-node/devContainersSpecCLI.ts Show resolved Hide resolved
@chrmarti chrmarti merged commit ff99677 into main Jan 19, 2023
@chrmarti chrmarti deleted the chrmarti/coastal-pinniped branch January 19, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants