Update install guidelines #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvalena
reviewed
Jun 25, 2018
| ``` | ||
|
|
||
| If you still wish to use `yarn` instead of `nodejs-yarn`, the best way is to use bash alias. |
There was a problem hiding this comment.
Can you include the alias example, please?
pvalena
reviewed
Jun 25, 2018
|
|
||
| ``` | ||
| $ sudo dnf install nodejs --releasever=25 | ||
| $ nodejs-yarn add request |
There was a problem hiding this comment.
I'd add a comment describing what is done, like so:
# Install package request using nodejs-yarn
[ . . ]
# Install package request using yarnpkg
pvalena
reviewed
Jun 25, 2018
|
|
||
| ``` | ||
| $ sudo dnf install npm | ||
| $ dnf info nodejs | ||
| $ dnf info nodejs --enablerepo rawhide |
There was a problem hiding this comment.
Rawhide repository is not included in basic Fedora install AFAIK, so this wouldn't work.
There was a problem hiding this comment.
This will soon work with just --releasever=30 instead of --enablerepo rawhide, right?
pvalena
reviewed
Jun 25, 2018
| @@ -4,36 +4,45 @@ subsection: nodejs | |||
| section: tech-languages | |||
| order: 1 | |||
| version: LTS | |||
There was a problem hiding this comment.
version variable is no longer used anywhere, could you remove it?
|
This branch is conflicting atm, please fix it. |
|
In general this looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.