Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native object spread support to babel-plugin-htm #99

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Add native object spread support to babel-plugin-htm #99

merged 3 commits into from
Jul 4, 2019

Conversation

jviide
Copy link
Collaborator

@jviide jviide commented Jul 3, 2019

This pull request adds support for native object spreads for babel-plugin-htm. Setting the new useNativeSpread parameter to true turns the support on. When the support is on input such as <div ...${a} b=${1} ...${c} /> would produce h("div", {...a, b:1, ...c}) instead of h("div", Object.assign({}, a, {b:1}, c)) .

This PR also adds tests for the new functionality.

@jviide jviide requested a review from developit July 3, 2019 23:26
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless execution 10/10

@jviide jviide merged commit 0ed6079 into developit:master Jul 4, 2019
@jviide jviide deleted the native-object-spread branch July 4, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants