Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9: use Object.create(null) over {} #11

Merged
merged 2 commits into from
Feb 25, 2017

Conversation

agudulin
Copy link
Contributor

Avoid object props inheritance.

@tunnckoCore
Copy link
Collaborator

👍

@developit
Copy link
Owner

Really want to merge this, but I can't seem to get it inside the 200b budget. Current work to get filesize down is here:
3a675c7

Let me know if you have any ideas 😇

@tunnckoCore
Copy link
Collaborator

it can just be 210 or even 212 because 1) it will include most prs, 2) is fancy, 3) still impressive as and small as 200.

@fregante
Copy link

fregante commented Jan 17, 2017

Agreed. While I'm all for nano modules (all my packages have a size badge) it's best not to get stuck on a number at the expense of quality. As long as it doesn't quadruple in size no one would complain.

Fun fact: momentjs started as a micro library and now it's a mega library.

@tunnckoCore
Copy link
Collaborator

@bfred-it yea.

@developit one more point is that mentioned commit it is duplicate code and kind of ugly.

@developit
Copy link
Owner

FWIW, I stopped using Moment because it grew too large for me to justify. I use date-fns now.

@developit developit merged commit af189c4 into developit:master Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants