Support transitionEnterTimeout & transitionLeaveTimeout #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassanbazzi
reviewed
Jun 9, 2017
| transition(animationType, finishCallback, timeout) { | ||
| let node = getComponentBase(this); | ||
|
|
||
| let className = this.props.name[animationType] || this.props.name + '-' + animationType; |
There was a problem hiding this comment.
Not sure what it's doing myself, but I am not super familiar with how this lib is used. Mybe @myarcane can give us some context :)
There was a problem hiding this comment.
Hi @hassanbazzi & @developit :
I didn't do anything particular here. I've just removed the grouped coma declaration. Nothing else !
And I think className is still needed 👉 https://github.com/myarcane/preact-css-transition-group/blob/663cd4e90dc8476290f955b5829d60ced9d89ff3/src/CSSTransitionGroupChild.js#L56
|
@hassanbazzi & @developit : can we merge the PR ? |
|
@developit please review ! |
|
Thx @developit 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
transitionEnterTimeout&transitionLeaveTimeoutare new<CSSTransitionGroup/>props.These props were already implemented in the original react repository. So this is simply a minimal port of the react implementation.
Why ?
In many cases, the
transitionendis not reliable (check #8 (comment)). Adding timeout is a way to solve the issue.How to use ?