Merge pull request #47 from tesselo/make-feature-geometry-optional

make feature geometry optional
developmentseed · Mar 4, 2022 · 9415f96 · 9415f96
2 parents 4608687 + 8c408ab
commit 9415f96
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/geojson_pydantic/features.py b/geojson_pydantic/features.py
@@ -9,7 +9,7 @@
 from geojson_pydantic.types import BBox
 
 Props = TypeVar("Props", bound=Dict)
-Geom = TypeVar("Geom", bound=Geometry)
+Geom = TypeVar("Geom", bound=Optional[Geometry])
 
 
 class Feature(GenericModel, Generic[Geom, Props]):

diff --git a/test/test_features.py b/test/test_features.py
@@ -40,6 +40,12 @@ class GenericProperties(BaseModel):
     "properties": properties,
 }
 
+test_feature_geom_null = {
+    "type": "Feature",
+    "geometry": None,
+    "properties": properties,
+}
+
 
 def test_geometry_collection_iteration():
     """test if feature collection is iterable"""
@@ -100,3 +106,8 @@ class Pointy:
 
     feat = Feature(geometry=Pointy())
     assert feat.geometry.dict() == Pointy.__geo_interface__
+
+
+def test_feature_with_null_geometry():
+    feature = Feature(**test_feature_geom_null)
+    assert feature.geometry is None