enable empty coordinantes #99
Conversation
| f"{self._wkt_inset}({self._wkt_coordinates})" | ||
| if self.coordinates | ||
| else " EMPTY" | ||
| ) |
There was a problem hiding this comment.
I removed the 2 abstract method because it was going to create more line of code (repeating the 2 if not self.coordinates)
There was a problem hiding this comment.
While there may need to be a couple extra safety checks to keep the type checking happy. Checking the value exists isn't an expensive operation but it cuts down on a lot of duplicated code to use the base functions.
I was actually going to propose a has_z property specifically to get rid of the _wkt_inset and get rid of the duplication of the " Z " if ... else " " everywhere.
| f"{self._wkt_inset}({self._wkt_coordinates})" | ||
| if self.coordinates | ||
| else " EMPTY" | ||
| ) |
There was a problem hiding this comment.
While there may need to be a couple extra safety checks to keep the type checking happy. Checking the value exists isn't an expensive operation but it cuts down on a lot of duplicated code to use the base functions.
I was actually going to propose a has_z property specifically to get rid of the _wkt_inset and get rid of the duplication of the " Z " if ... else " " everywhere.
| @@ -161,22 +154,31 @@ def check_closure(cls, coordinates: List) -> List: | |||
| @property | |||
| def exterior(self) -> LinearRing: | |||
| """Return the exterior Linear Ring of the polygon.""" | |||
| if not self.coordinates: | |||
There was a problem hiding this comment.
Initially I thought this would be a None, as there is not an exterior at all. But I guess [] could be valid as well.
| return self.coordinates[0] | ||
|
|
||
| @property | ||
| def interiors(self) -> Iterator[LinearRing]: | ||
| """Interiors (Holes) of the polygon.""" | ||
| if not self.coordinates: |
There was a problem hiding this comment.
I don't think this is necessary, as the current yield statement already covers this case.
I guess I mis understood this
|
closes #89
TODO: