Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undoMove method #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawid-niedzwiecki
Copy link

@dawid-niedzwiecki dawid-niedzwiecki commented Oct 8, 2022

(which worked only when moved pieces without capturing). There was this if statement:

    if (game.half_moves == 0) {
      return;
    }

which made it impossible to undo a move that was either a capturing move or pawn move (or both), since half_moves isn't the number of moves made. It's the number of moves counting towards the 50-move-draw rule. (Also the game.undo_move(); method is internally already checking if the game history is empty.)

It's a fix to issue #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant