chore: update UDI dockerfile to go1.18 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since ubi8 images now include go1.18 rpms, we need to update the go get command to go install; also dedupe the rpm cleanup commands and set an older tag so we can verify #21575 new GHA works Signed-off-by: Nick Boldt <[email protected]>
nickboldt
changed the title
9 tasks
…o with skopeo Signed-off-by: Nick Boldt <[email protected]>
ibuziuk
approved these changes
Dec 8, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nickboldt
deleted the
go118-doesn-t-work-with-go-get-switch-to-go-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: dockerfile update
since ubi8 images now include go1.18 rpms, we need to update the go get command to go install;
also dedupe the rpm cleanup commands and set an older tag so we can verify new GHA works with eclipse-che/che#21575
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Last good build: https://github.com/devfile/developer-images/actions/runs/3410216777/jobs/5672905276 (used golang 1.17 with
go get)Last build: https://github.com/devfile/developer-images/actions/runs/3643285736/jobs/6165373421 (used golang 1.18; failed due to error
'go get' is no longer supported outside a module.)How to test this PR?
merge it and watch https://github.com/devfile/developer-images/actions/workflows/ubi8-build.yaml
then check quay for new images at:
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.