Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Make check-bot check that base and alias have different values. #1486

Open
1 task done
Snailedlt opened this issue Oct 29, 2022 · 1 comment
Open
1 task done
Labels
devops Use this label for devops related enhancements enhancement

Comments

@Snailedlt
Copy link
Collaborator

Snailedlt commented Oct 29, 2022

I have searched through the issues and didn't find my problem.

  • Confirm

Problem

Currently it's possible to add a new entry to devicon.json with the following code:

"aliases": [
            {
                "base": "plain",
                "alias": "plain"
            }
        ]

Notice how the base and alias have the same value (plain). This does not make any sense, since the aliases attribute serves as a way to generate multiple font icon class name from just one SVG file (ref the documentation for aliases). So having plain as both an alias and base would only duplicate the class name.

Therefore we should make a check that fails if the base and alias are the same.

Possible Solution

It should be possible to add an extra check to our existing check-bot, in this script: https://github.com/devicons/devicon/blob/master/.github/scripts/check_icon_pr.py

Additional information

No response

@Snailedlt Snailedlt changed the title [FEATURE REQUEST] Make check-bot check that base and alias have different vaalues. [FEATURE REQUEST] Make check-bot check that base and alias have different values. Oct 29, 2022
@Snailedlt
Copy link
Collaborator Author

related to #1487 , specifically the devicon-schema.json: 97-210, which also checks that alias and base don't have the same names

@Panquesito7 Panquesito7 moved this to To-do in Devicons to-do Feb 8, 2023
@Panquesito7 Panquesito7 added the devops Use this label for devops related enhancements label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
Status: To-do
Development

No branches or pull requests

2 participants