-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix in devicon.json #1485
Conversation
Co-authored-by: David Leal <[email protected]>
- Remove unnecessary aliases of `sequelize` in `devicon.json`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of commits for a small change, consider redoing the branch or rebasing on develop next time, so it's easier for reviewers to look through it :)
That said, nice catch 🕵️
Thanks for making a PR on it, very much appreciated 🙏
@lunatic-fox |
I'll be doing that next time. |
@lunatic-fox hehe, yeah... In this case there was no issue, and it's rarely an issue for devicons since we do squash merging which squashes all of the commits into a single commit on the develop branch. However it could become an issue if there's a big feature, where you make multiple changes :) So just sort of a side note |
Btw, we should probably add this alias/base duplicate value check to our |
That's great! |
* Add Ren'Py * Update devicon.json Co-authored-by: David Leal <[email protected]> * Fix versions and aliases of `handlebars` and `yarn` * Bugfix/fix in devicon.json - Remove unnecessary aliases of `sequelize` in `devicon.json` Co-authored-by: David Leal <[email protected]>
Double check these details before you open a PR
Features
Removes unnecessary aliases of
sequelize
indevicon.json
This PR closes NONE
Notes