-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: Axios (plain,plain-wordmark) #1087
new icon: Axios (plain,plain-wordmark) #1087
Conversation
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Don't worry about the check-bot's message for now. We are currently fixing the issue. |
@Thomas-Boi Thanks, I did saw in another PR that the same error popped so I thought it was the case 😅 If there's any change needed though let me know 👍🏼 |
Hi @JorchCortez can you rebase this branch off the latest develop? That should fix the peek icon issues. |
f56d870
to
de3917d
Compare
@Thomas-Boi I just did the rebase to latest develop, if there's any other error let me know, worst case scenario I make the changes again 👍🏼 |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the contribution!
My mistake: did not squash-merged, @Thomas-Boi is this a big problem? |
I don't think so. It all depends on how many commits are there. This one only has 1 commit so it should be fine. Even if there's more than one, the only issue is it makes for a cluttered history but no problem with our pipeline. |
…/addAxiosIcon new icon: Axios (plain,plain-wordmark)
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1056
Link to prove your SVG is correct and up-to-date.
Axios http website