-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: rider (original, plain-wordmark) #1106
Conversation
This reverts commit 7dda239.
I feel there might be an issue with the plain-wordmark file, while looking at it with the transparency grid I had not noticed the white text is a while fill, not transparent. If need be, close this PR and I will resubmit the wordmark as original-wordmark in a new PR. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go now. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icons looking good so far, but we require a original
or plain
version as statet in our requirements https://github.com/devicons/devicon/wiki/SVG-Versions. The wordmark version for the font is not enough so satisfy this requiredment. Maybe you could create a plain
version?
Is the |
Sorry. My answer was incomplete: We need a |
Got it, thanks for clarifying |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
* Add Rider icons * Add Rider icons This reverts commit 7dda239. * Fixed Rider wordmark icon * Added plain variation
* Add Rider icons * Add Rider icons This reverts commit 7dda239. * Fixed Rider wordmark icon * Added plain variation
* Add Rider icons * Add Rider icons This reverts commit 7dda239. * Fixed Rider wordmark icon * Added plain variation
* Add Rider icons * Add Rider icons This reverts commit 7dda239. * Fixed Rider wordmark icon * Added plain variation
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1071
Link to prove your SVG is correct and up-to-date.
Rider product site