new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1226

kilianpaquier · 2022-06-23T17:39:54Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #404

Link to prove your SVG is correct and up-to-date.

https://nhibernate.info/
https://github.com/nhibernate

…ark) - fix #404

github-actions · 2022-06-23T18:44:18Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7

LGTM 🚀 Thank you for your contribution! 😄👍

__
Summary: 🏆 This code is awesome | Tags: Efficient, Elegant

kilianpaquier · 2022-06-23T19:45:23Z

Almost, there's an issue with the original font, the eye isn't shown on the non-colored font.

I also didn't expected the original's colors to be unique, as shown on the original svg, I expected two colors. I'm going to adapt the original and the plain to avoid duplicates svg

kilianpaquier · 2022-06-23T19:58:59Z

Removed the generation of a font for the original svg, was a duplicate of the plain font

Panquesito7

Could you please fix the merge conflicts on the devicon.json file?
Let us know if you need any help with that! 🙂

__
Summary: 🛠️ This code needs a fix | Tags: Not reusable

…ernate

kilianpaquier · 2022-06-24T06:45:28Z

Rebase done

Panquesito7

Awesome. Thank you for your contribution! 🚀
I'll merge in the next few days if there are no objections.

__
Summary: 🏆 This code is awesome | Tags: Efficient, Elegant

Snailedlt

LGTM!

Snailedlt · 2022-07-14T02:16:53Z

@Panquesito7 time to merge? :)

github-actions · 2022-07-17T13:47:53Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

Suggested some other tags.
If you want you can also try to make line icons for it :)

devicon.json

Co-authored-by: Snailedlt <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

kilianpaquier · 2022-07-17T15:00:53Z

Suggested some other tags. If you want you can also try to make line icons for it :)

Something like that ?

Snailedlt · 2022-07-17T21:55:16Z

Yeah, something like that :)

kilianpaquier · 2022-07-18T08:02:36Z

And like that?

Snailedlt · 2022-07-18T11:56:52Z

@kilian-paquier yes, but it should only have a single color. See https://github.com/devicons/devicon/wiki/SVG-Standards and https://github.com/devicons/devicon/wiki/SVG-Versions

kilianpaquier · 2022-07-22T10:02:00Z

Hello, yes. That was just a draft to show which parts were going to be "lined". I've made the changes.

github-actions · 2022-07-23T20:43:55Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

Very nice!
Thanks again for contributing! 💯

…ark, line, line-wordmark) (devicons#1226) * new icon: nhibernate (original, original-wordmark, plain, plain-wordmark) - fix devicons#404 * nhibernate| removed original font and kept svg only * nhibernate| removed plain svg * nhibernate| adapt font versions with review * nhibernate| added plain svg to svg versions * nhibernate| removed plain versions from svg * nhibernate| optimize plain svg's * nhibernate| added tags Co-authored-by: Snailedlt <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * nhibernate| added line icons Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

new icon: nhibernate (original, original-wordmark, plain, plain-wordm…

e0ce7b0

…ark) - fix #404

Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 23, 2022

Panquesito7 previously approved these changes Jun 23, 2022

View reviewed changes

Panquesito7 requested a review from amacado June 23, 2022 19:40

nhibernate| removed original font and kept svg only

96bba23

kilianpaquier dismissed Panquesito7’s stale review via 96bba23 June 23, 2022 19:58

nhibernate| removed plain svg

7440f71

Panquesito7 requested changes Jun 24, 2022

View reviewed changes

kilianpaquier changed the title ~~new icon: nhibernate (original, original-wordmark, plain, plain-wordmark)~~ new icon: nhibernate (original, original-wordmark) Jun 24, 2022

Merge branch 'develop' of github.com:kilian-paquier/devicon into nhib…

b84e222

…ernate

Panquesito7 previously approved these changes Jun 27, 2022

View reviewed changes

nhibernate| adapt font versions with review

34fb840

kilianpaquier dismissed Panquesito7’s stale review via 34fb840 June 27, 2022 17:54

nhibernate| added plain svg to svg versions

849e006

kilianpaquier changed the title ~~new icon: nhibernate (original, original-wordmark)~~ new icon: nhibernate (original, original-wordmark, plain, plain-wordmark) Jun 27, 2022

Kilian PAQUIER added 2 commits June 27, 2022 20:09

nhibernate| removed plain versions from svg

916e010

nhibernate| optimize plain svg's

4a8797a

Snailedlt previously approved these changes Jul 14, 2022

View reviewed changes

Merge branch 'develop' into nhibernate

03a6c09

kilianpaquier dismissed Snailedlt’s stale review via 03a6c09 July 14, 2022 07:06

merge branch 'develop'

04ee10f

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 17, 2022

Snailedlt requested changes Jul 17, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

nhibernate| added tags

614eedb

Co-authored-by: Snailedlt <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

nhibernate| added line icons

f2d93da

kilianpaquier changed the title ~~new icon: nhibernate (original, original-wordmark, plain, plain-wordmark)~~ new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Jul 22, 2022

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 23, 2022

Snailedlt approved these changes Jul 23, 2022

View reviewed changes

Snailedlt merged commit e327ae6 into devicons:develop Jul 23, 2022

kilianpaquier deleted the nhibernate branch July 24, 2022 09:09

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1226

new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1226

kilianpaquier commented Jun 23, 2022 •

edited

Loading

github-actions bot commented Jun 23, 2022

Panquesito7 left a comment

kilianpaquier commented Jun 23, 2022

kilianpaquier commented Jun 23, 2022

Panquesito7 left a comment

kilianpaquier commented Jun 24, 2022

Panquesito7 left a comment

Snailedlt left a comment

Snailedlt commented Jul 14, 2022

github-actions bot commented Jul 17, 2022

Snailedlt left a comment

kilianpaquier commented Jul 17, 2022

Snailedlt commented Jul 17, 2022

kilianpaquier commented Jul 18, 2022

Snailedlt commented Jul 18, 2022

kilianpaquier commented Jul 22, 2022

github-actions bot commented Jul 23, 2022

Snailedlt left a comment

new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1226

new icon: nhibernate (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1226

Conversation

kilianpaquier commented Jun 23, 2022 • edited Loading

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

github-actions bot commented Jun 23, 2022

Panquesito7 left a comment

Choose a reason for hiding this comment

kilianpaquier commented Jun 23, 2022

kilianpaquier commented Jun 23, 2022

Panquesito7 left a comment

Choose a reason for hiding this comment

kilianpaquier commented Jun 24, 2022

Panquesito7 left a comment

Choose a reason for hiding this comment

Snailedlt left a comment

Choose a reason for hiding this comment

Snailedlt commented Jul 14, 2022

github-actions bot commented Jul 17, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

kilianpaquier commented Jul 17, 2022

Snailedlt commented Jul 17, 2022

kilianpaquier commented Jul 18, 2022

Snailedlt commented Jul 18, 2022

kilianpaquier commented Jul 22, 2022

github-actions bot commented Jul 23, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

kilianpaquier commented Jun 23, 2022 •

edited

Loading