-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: hibernate (original, original-wordmark, plain, plain-wordmark) #1227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, this PR has merge conflicts which need to be solved before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.jmdoudoux.fr/java/dej/chap-hibernate.htm The only difference between nhibernate and hibernate is the target language. |
@kilian-paquier Okey, so hibernate is the company/organization name, and hibernate ORM is the product name. But then the product is also called hibernate (quite confusing if you ask me). So then, shouldn't the name be |
Hibernate is a framework, it seems to be owned by Red Hat, but it's open source. Hibernate provides functionalities/libraries/tools, such as the hibernate ORM, validator, etc. All the functionalities come with the same logo. Here's the GitHub link of hibernate : https://github.com/hibernate |
Yeah, looking at their twitter account it says something like "...hibernate is a suite of open-source projects..." @Panquesito7 Looks like this is a suite of products (not a single one), do you think it qualifies for devicons? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by me, but will wait for other maintainers to see if they think it's an icon that should be accepted or not.
@devicons/maintainer Please take a look at the comments on this PR
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🙇
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rk) (devicons#1227) * new icon: hibernate (original, original-wordmark) * hibernate| added plain, plain-wordmark versions * hibernate| removed plain versions from svg * hibernate| changed primary color from hibernate logo * hibernate| optimize plain svg's * hibernate| moved object in devicon.json * Update devicon.json Co-authored-by: David Leal <[email protected]> Co-authored-by: David Leal <[email protected]>
…rk) (devicons#1227) * new icon: hibernate (original, original-wordmark) * hibernate| added plain, plain-wordmark versions * hibernate| removed plain versions from svg * hibernate| changed primary color from hibernate logo * hibernate| optimize plain svg's * hibernate| moved object in devicon.json * Update devicon.json Co-authored-by: David Leal <[email protected]> Co-authored-by: David Leal <[email protected]>
…rk) (devicons#1227) * new icon: hibernate (original, original-wordmark) * hibernate| added plain, plain-wordmark versions * hibernate| removed plain versions from svg * hibernate| changed primary color from hibernate logo * hibernate| optimize plain svg's * hibernate| moved object in devicon.json * Update devicon.json Co-authored-by: David Leal <[email protected]> Co-authored-by: David Leal <[email protected]>
…rk) (devicons#1227) * new icon: hibernate (original, original-wordmark) * hibernate| added plain, plain-wordmark versions * hibernate| removed plain versions from svg * hibernate| changed primary color from hibernate logo * hibernate| optimize plain svg's * hibernate| moved object in devicon.json * Update devicon.json Co-authored-by: David Leal <[email protected]> Co-authored-by: David Leal <[email protected]>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
https://hibernate.org/