-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: envoy (original, original-wordmark, plain, plain-wordmark) #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I chose approve instead of request changes.
Rebase done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo the icon should be renamed to envoy, since the website and logo calls it that. Please tell me if I'm wrong though.
Other than that, there's just one comment on a tag.
PS: When renaming the icon, remember to rename the files, folders and PR title too
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
@Panquesito7 one of the checks is failing because the PR title was changed after the PR was made. I've re-ran the job, but it didn't work. Any ideas on how to fix it? |
The first commit needed to be renamed too |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…evicons#1228) * new icon: envoy (original, original-wordmark) * renaming old commit * removed bad object in devicon.json * fix envoy after rebase
…evicons#1228) * new icon: envoy (original, original-wordmark) * renaming old commit * removed bad object in devicon.json * fix envoy after rebase
…evicons#1228) * new icon: envoy (original, original-wordmark) * renaming old commit * removed bad object in devicon.json * fix envoy after rebase
…evicons#1228) * new icon: envoy (original, original-wordmark) * renaming old commit * removed bad object in devicon.json * fix envoy after rebase
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
https://www.envoyproxy.io/
https://www.envoyproxy.io/docs/envoy/latest/start/start