Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1273

Merged
merged 4 commits into from
Jul 24, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 17, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format update icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here

This PR closes #872

Link to prove your SVG is correct and up-to-date.

https://brand.unity.com/
https://brandguide.brandfolder.com/unity/unitylogo
https://unity.com/fr

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 23, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add
"c-sharp" and "C#" as tags to this one :)

@Snailedlt
Copy link
Collaborator

You should add "c-sharp" and "C#" as tags to this one :)

Added this myself, so I can merge this before I go to bed. Hope you don't mind :)

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Thanks for contributing! 💯

@Snailedlt Snailedlt merged commit 80b4eb4 into devicons:develop Jul 24, 2022
@kilianpaquier kilianpaquier deleted the unity branch July 24, 2022 09:09
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k, line, line-wordmark) (devicons#1273)

* update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) - fix devicons#872

* unity| reviewed size of no wordmark icons

* unity| reviewed size of no wordmark icons

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k, line, line-wordmark) (devicons#1273)

* update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) - fix devicons#872

* unity| reviewed size of no wordmark icons

* unity| reviewed size of no wordmark icons

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k, line, line-wordmark) (devicons#1273)

* update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) - fix devicons#872

* unity| reviewed size of no wordmark icons

* unity| reviewed size of no wordmark icons

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…k, line, line-wordmark) (devicons#1273)

* update icon: unity (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) - fix devicons#872

* unity| reviewed size of no wordmark icons

* unity| reviewed size of no wordmark icons

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants