-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sort devicon json and add sort check #1405
Feature/sort devicon json and add sort check #1405
Conversation
The sorting of devicon.json in this PR needs to be redone because devicon.json has been updated since it was last sorted |
Sort `devicon.json` of commit `77ff589df1fcffde36d9f3239d658046663d5588` from `develop` branch.
Code used to sort import json
path = 'devicon.json'
with open(path) as file:
file: list[dict] = json.load(file)
file.sort(key=lambda e: e['name'])
file = json.dumps(file, indent=4) + '\n'
with open(path, 'w') as output_file:
output_file.write(file) |
@lunatic-fox did you check if the check-icon script deemed it as sorted? |
Not yet, I'll do later some tests in a private repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Josélio Júnior <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devicon.json
is up-to-date and sorted with its latest version: eb35d73- Conflicts are resolved.
Looking good! ✔
Thank you for this great feature! 🚀
* indent and sort devicon.json * add check to see if devicon.json is sorted * Update devicon.json Sort `devicon.json` of commit `1252ce95619756b5c237c72c605288e5eadc118f` from `develop` branch. * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Josélio Júnior <[email protected]> * Update `devicon.json` with 5460505 Co-authored-by: unknown <[email protected]> Co-authored-by: Josélio Júnior <[email protected]>
Double check these details before you open a PR
Features
devicon.json
check_icon_pr.py
to see if devicon.json is still sortedThis PR closes #1337, #1327
Notes
Please check both if the functionality looks sound, and if the error messages can be improved