Feature/update check icon pr py #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
added
enhancement
devops
Snailedlt
requested review from
Thomas-Boi,
a team,
amacado and
Panquesito7
and removed request for
a team
Thomas-Boi
previously approved these changes
Oct 2, 2022
There was a problem hiding this comment.
Hey @Snailedlt,
The PR looks great 👍 . The checks make sense to me and it seems like we now have a altname field in the object. This should be a great feature for the checking script. I'll approve this PR. However, I'm not a maintainer anymore so please double check with the others just in case.
Good luck with future PRs. I think you'll be a great member for the Devicon maintainer team 😄
|
@Panquesito7 please check this out when you have time :) |
Snailedlt
added
the
hacktoberfest-accepted
lunatic-fox
requested changes
Dec 11, 2022
Apply suggestions from code review. Thanks @lunatic-fox Co-authored-by: Josélio Júnior <[email protected]>
Panquesito7
reviewed
Feb 1, 2023
Snailedlt
commented
Feb 1, 2023
Snailedlt
commented
Feb 1, 2023
Snailedlt
commented
Feb 1, 2023
Snailedlt
commented
Feb 1, 2023
Apply suggestions from code review Co-authored-by: David Leal <[email protected]>
Panquesito7
reviewed
Feb 9, 2023
|
@lunatic-fox if this looks okey to you I can go ahead and merge it to develop :) |
lunatic-fox
approved these changes
Mar 17, 2023
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* add check for 'name' attribute * add check for 'altnames' attribute * add extra check for content of aliases field in devicon.json * Change from single quotes to escaped double quotes Apply suggestions from code review. Thanks @lunatic-fox Co-authored-by: Josélio Júnior <[email protected]> * Replace ' with \" Apply suggestions from code review Co-authored-by: David Leal <[email protected]> --------- Co-authored-by: Josélio Júnior <[email protected]> Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
baseand `alias, and that they both match the regexp: (original|plain|line)(-wordmark)?This PR closes NONE
Notes