-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: djangorest (original, plain, original-wordmark, plain-wordmark) #1407
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Co-Authored-By: kilianpaquier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last suggestions hopefully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Great work to everyone involved! 💯 It's not every day that we get to add all icon versions for a logo, let alone in the same PR!
Special thanks to @BenSouchet @lunatic-fox @kilianpaquier and @Panquesito7 for contributions both in the form of code, reviews and discussions!
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approved, hope it's good now :)
…ark) (devicons#1407) * Add Django REST Framework * Add `line` and `line-wordmark` versions Co-Authored-By: kilianpaquier <[email protected]> * Add empty lines at the end of `.svg` files * Add line to font Co-authored-by: kilianpaquier <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1387
Link to prove your SVG is correct and up-to-date.
https://www.django-rest-framework.org/img/logo.png