-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: livewire (original, original-wordmark, plain, plain-wordmark) #1415
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
Thank you for your continued contributions,! 💯
Looking forward to the next one 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woopsie
@Panquesito7 like we discussed on Discord, it seems like icomoon isn't rendering the icon fonts correctly with the masks. Notice in the images below how the screenshots from icomoon don't have the eye cutout, while the SVG versions uploaded here do.
Comparison
How they should look
How they look on icomoon
Summary
The plain icons need to be fixed (or removed) before merging to develop
What should we do about it, then? 🤔 |
Either remove the plain icons or find another way to clip out the shapes. I suggest trying to do it with inkscape like so: https://graphicdesign.stackexchange.com/a/42590 |
11a4c01
to
4e36b04
Compare
4e36b04
to
342b30e
Compare
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
342b30e
to
cb7c597
Compare
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Nice! It finally looks good. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! ✔️
Kinda sad you force pushed so I can't see the diff easily, but as long as it works I guess it's okey :)
…k) (devicons#1415) Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
…k) (devicons#1415) Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
…k) (devicons#1415) Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
…k) (devicons#1415) Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Double check these details before you open a PR
Special thanks to @Snailedlt for their tremendous help! 🚀
develop
branch.devicon.json
file as seen hereThis PR closes #855
Link to prove your SVG is correct and up-to-date.
https://laravel-livewire.com/