Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: yaml (original, plain) #1448

Merged
merged 7 commits into from
Dec 10, 2022
Merged

new icon: yaml (original, plain) #1448

merged 7 commits into from
Dec 10, 2022

Conversation

lunatic-fox
Copy link
Contributor

@lunatic-fox lunatic-fox commented Oct 12, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here
This PR closes #1446

Link to prove your SVG is correct and up-to-date.

https://upload.wikimedia.org/wikipedia/commons/5/5a/Official_YAML_Logo.svg

Snailedlt
Snailedlt requested changes Oct 14, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 14, 2022
@Snailedlt Snailedlt mentioned this pull request Oct 14, 2022
Merged
6 tasks
@lunatic-fox @Snailedlt
Update devicon.json
6faac64 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@lunatic-fox lunatic-fox changed the title new icon: yaml (original-wordmark, plain-wordmark) new icon: yaml (original, plain) Oct 14, 2022
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 14, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great contribution! ✔️ 🚀

@KayleeDavisGitHub
Copy link

Thank you both <3

@weh weh mentioned this pull request Oct 26, 2022
Closed
1 task
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
@Snailedlt Snailedlt merged commit 9ed85c7 into devicons:develop Dec 10, 2022
@stla
Copy link

stla commented May 25, 2023

Hello,

This PR has been merged. However I don't find the YAML icon in the repo. I looked in the svg folder and in the css file.

@PantheraRed
Copy link
Contributor

Hello,

This PR has been merged. However I don't find the YAML icon in the repo. I looked in the svg folder and in the css file.

Here you go: https://github.com/devicons/devicon/tree/develop/icons/yaml
also check :)

@lunatic-fox lunatic-fox deleted the add_yaml branch June 1, 2023 12:28
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@lunatic-fox @Panquesito7 @Snailedlt
new icon: yaml (original, plain) (devicons#1448)
c0ac2c8 
* Add Ren'Py

* Update devicon.json

Co-authored-by: David Leal <[email protected]>

* Add YAML

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Fix icon names and `devicon.json` aliases quotes

Co-authored-by: David Leal <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunatic-fox @KayleeDavisGitHub @stla @PantheraRed @Snailedlt