Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: wasm (original, original-wordmark, plain, plain-wordmark) #1456

Merged
merged 7 commits into from
Nov 11, 2022
Merged

new icon: wasm (original, original-wordmark, plain, plain-wordmark) #1456

merged 7 commits into from
Nov 11, 2022

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 14, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

closes #367

Link to prove your SVG is correct and up-to-date.

https://github.com/carlosbaraza/web-assembly-logo

@Snailedlt Snailedlt changed the title new icon: wasm (original, original-wordmar, plain, plain-wordmark) new icon: wasm (original, original-wordmark, plain, plain-wordmark) Oct 14, 2022
Snailedlt
Snailedlt requested changes Oct 15, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
icons/wasm/wasm-plain.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 15, 2022
weh and others added 3 commits October 18, 2022 10:12
@weh @Snailedlt
Add language tag
6edfdbf 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@weh @Snailedlt
Replace plain file with alias
2f3c356 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@weh
Delete wasm-plain file
a94acf9
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 19, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉
Thanks for your contribution! 🙇

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
lunatic-fox
lunatic-fox requested changes Nov 8, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
icons/wasm/wasm-original.svg Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox requested a review from Snailedlt November 9, 2022 23:45
@weh @lunatic-fox
Fix color
c2d4f3c 
Co-authored-by: Josélio Júnior <[email protected]>
@weh @lunatic-fox
Remove white stroke from svg
c4c4478 
Co-authored-by: Josélio Júnior <[email protected]>
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 10, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Nov 10, 2022
View reviewed changes
lunatic-fox
lunatic-fox previously approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this great contribution! 🎉

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox dismissed stale reviews from Snailedlt and themself via e504fd8 November 11, 2022 02:11
@Snailedlt Snailedlt merged commit 242de5e into devicons:develop Nov 11, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@weh @Snailedlt @lunatic-fox
new icon: wasm (original, original-wordmark, plain, plain-wordmark) (d…
6b6259c 
…evicons#1456)

* new icon: wasm (original, original-wordmar, plain, plain-wordmark)

* Add language tag

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Replace plain file with alias

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Delete wasm-plain file

* Fix color

Co-authored-by: Josélio Júnior <[email protected]>

* Remove white stroke from svg

Co-authored-by: Josélio Júnior <[email protected]>

* Adjusting array structure

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weh @Snailedlt @lunatic-fox