-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: vite (original, original-wordmark) #1472
Conversation
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up this PR, this is a great addition to the project 🚀
LGTM ✔️
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some changes.
Approved! ✔
Thank you for this contribution! 🚀
@lunatic-fox Could you please share a guide on how to remove those bug lines that show up in the icomoon preview? :) |
I want to, but it depends of the icon. Some tips of how to proceed when this bug happens
I seriously wish to detail it quite more, but I hope those tips make this issue at least a little bit clear. |
@lunatic-fox Thanks, that helped a bit :) Would love it if you went through an example, and showed before and after code+preview. An explanation for some of the terms like I think if you use the template of your answer above, add some explanations, examples, code snippets and screenshots/previews, the guide would be more than good enough! We just need to know how to identify the nature of the issue, and what the usual causes are, then finding out how to fix it becomes much easier with some examples too :) |
* Adding Vite * Add files via upload * Removing ViteJS * Rename vite-plain-wordmark.svg to vite-original-wordmark.svg * Rename vite-plain.svg to vite-original.svg * Update devicon.json * vite| update images for standards * Remove bug line on `original-wordmark` and resize icons to fit the box Co-authored-by: Acme Gamers <[email protected]> Co-authored-by: Josélio Júnior <[email protected]>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Reworking this PR : #1251
Link to prove your SVG is correct and up-to-date.
https://www.vite.org/