Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: vite (original, original-wordmark) #1472

Merged
merged 9 commits into from
Dec 1, 2022
Merged

new icon: vite (original, original-wordmark) #1472

merged 9 commits into from
Dec 1, 2022

Conversation

kilianpaquier
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Reworking this PR : #1251

Link to prove your SVG is correct and up-to-date.

https://www.vite.org/

@Snailedlt Snailedlt requested review from Snailedlt and Panquesito7 and removed request for Snailedlt October 26, 2022 09:00
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 30, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Oct 31, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this PR, this is a great addition to the project 🚀

LGTM ✔️

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox requested a review from Snailedlt December 1, 2022 10:15
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes.

Approved! ✔
Thank you for this contribution! 🚀

@Snailedlt
Copy link
Collaborator

@lunatic-fox Could you please share a guide on how to remove those bug lines that show up in the icomoon preview? :)

@lunatic-fox
Copy link
Contributor

@lunatic-fox Could you please share a guide on how to remove those bug lines that show up in the icomoon preview? :)

I want to, but it depends of the icon.
However there is some kind of pattern, so let's take a look.

Some tips of how to proceed when this bug happens

  • Try to identify where the bug line begins.
  • See if there is any unnecessary node like:
    • A curve node between some line segment.
    • A node that is not preserving the shape of a curve segment.
  • See if there is a line segment made by two curve nodes.
  • Once identified you can:
    • Remove those unnecessary nodes, taking care to preserve the shape.
    • Or rebuild the shape.

I seriously wish to detail it quite more, but I hope those tips make this issue at least a little bit clear.

@Snailedlt
Copy link
Collaborator

@lunatic-fox Thanks, that helped a bit :)

Would love it if you went through an example, and showed before and after code+preview.

An explanation for some of the terms like node, curve segment, curve node, line segment and so on would also be nice. What is a node? How does it look in the code? How do I identify where the bug line begins?

I think if you use the template of your answer above, add some explanations, examples, code snippets and screenshots/previews, the guide would be more than good enough!

We just need to know how to identify the nature of the issue, and what the usual causes are, then finding out how to fix it becomes much easier with some examples too :)

@Snailedlt Snailedlt merged commit d58d3f0 into devicons:develop Dec 1, 2022
@kilianpaquier kilianpaquier deleted the vite branch January 3, 2023 14:29
@lunatic-fox lunatic-fox mentioned this pull request Jan 28, 2023
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Adding Vite

* Add files via upload

* Removing ViteJS

* Rename vite-plain-wordmark.svg to vite-original-wordmark.svg

* Rename vite-plain.svg to vite-original.svg

* Update devicon.json

* vite| update images for standards

* Remove bug line on `original-wordmark` and resize icons to fit the box

Co-authored-by: Acme Gamers <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants