Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: pfsense (original, original-wordmark) #1508

Merged
merged 6 commits into from
Nov 22, 2022
Merged

new icon: pfsense (original, original-wordmark) #1508

merged 6 commits into from
Nov 22, 2022

Conversation

yeyeto2788
Copy link
Contributor

@yeyeto2788 yeyeto2788 commented Nov 14, 2022 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1193

Link to prove your SVG is correct and up-to-date.

seyitErdemir
seyitErdemir reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@seyitErdemir seyitErdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

success

@lunatic-fox
Copy link
Contributor

Hello there!

The icon seems to be the original-wordmark version of the icon and it does have an original version:

original

original-wordmark -> pfSense SVG logo

Unfortunately original version doesn't have a SVG version, but I think you can use their SVG logo as base to make both icons.

Wish for the best! 🚀

lunatic-fox
lunatic-fox reviewed Nov 16, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 18, 2022
@yeyeto2788
Copy link
Contributor Author

Hey! sorry for the delay. I hope I covered all changes.

@lunatic-fox lunatic-fox changed the title new icon: pfsense (original) new icon: pfsense (original, original-wordmark) Nov 18, 2022
@lunatic-fox
Copy link
Contributor

No problem! 🙂
I've made some changes. 📝

  • 15d67c5
    • devicon.json
      • altnames - change "pfsense" to "pfSense"
      • versions.font - added "original-wordmark"
    • pfsense-original-wordmark.svg
      • Removed unnecessary attributes

Snailedlt
Snailedlt requested changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, just some minor changes needed :)

devicon.json Outdated
@@ -9111,5 +9111,35 @@
},
"color": "#2684FF",
"aliases": []
},
{
"name": "pfsense",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved to the correct place in devicon.json, so that the file is alphabetically sorted.

I can see why this is confusing though, since some are not in the correct place. These will be fixed in the future, and an automatic check will be added so you get faster feedback on it too :)

devicon.json Outdated Show resolved Hide resolved
icons/pfsense/pfsense-original-wordmark.svg Show resolved Hide resolved
icons/pfsense/pfsense-original.svg Outdated Show resolved Hide resolved
@yeyeto2788
Copy link
Contributor Author

Does it really differ from the one I uploaded? The one on the PR is directly from their website which in also SVG (I guess it is the same though)

@Snailedlt
Copy link
Collaborator

Does it really differ from the one I uploaded? The one on the PR is directly from their website which in also SVG (I guess it is the same though)

@yeyeto2788 no idea honestly. Just wanted to make sure we have the most coreect one, and I assumed you made the previous one out of the wordmark-version

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Nov 21, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for your contribution 🚀

lunatic-fox
lunatic-fox requested changes Nov 21, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@yeyeto2788 @lunatic-fox
Update devicon.json
3188b93 
Co-authored-by: Josélio Júnior <[email protected]>
lunatic-fox
lunatic-fox approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 2e57212 into devicons:develop Nov 22, 2022
@yeyeto2788 yeyeto2788 deleted the pfsense branch March 7, 2023 09:04
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@yeyeto2788 @lunatic-fox @Snailedlt
new icon: pfsense (original, original-wordmark) (devicons#1508)
4e48615 
* Add pfsense icon

* Add original wordmark.

* Remove unnecessary attributes of "original-wordmark" and fix "devicon.json"

* Update icons/pfsense/pfsense-original.svg

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Order alphabetically the objects in devicons.json

* Update devicon.json

Co-authored-by: Josélio Júnior <[email protected]>

Co-authored-by: Juan Biondi <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seyitErdemir seyitErdemir seyitErdemir left review comments

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeyeto2788 @lunatic-fox @Snailedlt @seyitErdemir