-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: phoenix (original, original-wordmark, plain, plain-wordmark) #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can ask some of the phoenix framework devs or their logo designer if they have a .svg version of the vertical wordmark version?
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
@cyberalien does this look good to you too? |
Looks good |
…ark) (devicons#1535) * Fix Phoenix * change icons
Double check these details before you open a PR
Features
original-wordmark
andplain-wordmark
versionsplain
versiondevicon.json
entryThis PR closes #1519, #1528 and #1529
Notes