-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: zsh (original, plain) #1648
Conversation
Fix issue with npm publish script
Build preparation for release v2.15.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for the contribution! Always good to see new people helping out!
That said there are a few things that need to be fixed with this PR before it can be merged. Before I name all the things that need to be fixed, I suggest you look at the wiki and try to fix most of it yourself, then you can make a new PR, and ask for a review again :)
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi again @Shoaib19, do you need any help with this? We're more than willing to help if needed! |
Could you share the platform where you used to create svgs so I can make this one according to standard otherwise I will open issue and let someone can create it. |
Sure. You can find the tools we use and recommend here: https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools You can also find specific tutorials in the comment section of this issue: #1306 Hope this helps :) |
Oh, and let me know if you need any more help! :) |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠ Please don't use plain images inside the .svg
file.
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
zsh official site