Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: zsh (original, plain) #1648

Closed
wants to merge 9 commits into from
Closed

Conversation

Shoaib19
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

zsh official site

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for the contribution! Always good to see new people helping out!

That said there are a few things that need to be fixed with this PR before it can be merged. Before I name all the things that need to be fixed, I suggest you look at the wiki and try to fix most of it yourself, then you can make a new PR, and ask for a review again :)

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



SVG Error in 'zsh-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'zsh-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt
Copy link
Collaborator

Hi again @Shoaib19, do you need any help with this? We're more than willing to help if needed!

@Shoaib19
Copy link
Author

Could you share the platform where you used to create svgs so I can make this one according to standard otherwise I will open issue and let someone can create it.

@Snailedlt
Copy link
Collaborator

Could you share the platform where you used to create SVGs so I can make this one according to standard otherwise I will open issue and let someone can create it.

Sure. You can find the tools we use and recommend here: https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools

You can also find specific tutorials in the comment section of this issue: #1306

Hope this helps :)

@Snailedlt
Copy link
Collaborator

Oh, and let me know if you need any more help! :)

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Error found in "devicon.json" for "zsh" entry: 
- Missing property key: "altnames".

SVG Error in 'zsh-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'zsh-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:



SVG Error in 'zsh-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'zsh-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@lunatic-fox lunatic-fox changed the title new icon: zsh (original) new icon: zsh (original, plain) Mar 23, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠ Please don't use plain images inside the .svg file.

@Shoaib19 Shoaib19 closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants