Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and use Geckodriver for Linux64 #1663

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Update and use Geckodriver for Linux64.
    • We might want to make sure the newest Geckodriver version works. If it doesn't, we can always revert back to the other version.
    • The Windows build is kept in the build_assets folder in case it's needed again. If wanted, we can delete it.

@Panquesito7 Panquesito7 added the devops Use this label for devops related enhancements label Feb 3, 2023
@Snailedlt
Copy link
Collaborator

Did you test it yet?

@Panquesito7
Copy link
Member Author

Did you test it yet?

The Linux build works fine. I haven't tested the new version.
Will test it right away. I don't think anything will break, but still. 🙂

@Panquesito7
Copy link
Member Author

Tested and works properly. 👍

@Snailedlt
Copy link
Collaborator

Alright, let's test it out in the draft-release branch as well :)

@Snailedlt Snailedlt merged commit dc45356 into draft-release Feb 4, 2023
@Panquesito7 Panquesito7 deleted the geckodriver_linux branch February 7, 2023 03:21
@Panquesito7
Copy link
Member Author

Should we create this PR for the develop branch (along with #1667 and #1671)?
The draft-release branch will be deleted as new icons/things have been added now.

@Panquesito7 Panquesito7 restored the geckodriver_linux branch February 9, 2023 23:12
@Snailedlt
Copy link
Collaborator

@Panquesito7 yes, create PRs toward develop :)

@Panquesito7 Panquesito7 deleted the geckodriver_linux branch February 10, 2023 19:02
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants